Fix ConcurrentModificationException on commitLater#476
Merged
Conversation
Invocations of consumer.commitAsync should be protected under the consumer semaphore, or you get errors like this when trying to call commitLater concurrently with poll: java.util.ConcurrentModificationException: KafkaConsumer is not safe for multi-threaded access
Contributor
Author
|
I want also to make a minor release when this fix is merged. |
Pull Request Test Coverage Report for Build 14110240777Details
💛 - Coveralls |
Z1kkurat
approved these changes
Mar 27, 2025
mr-git
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invocations of Java consumer's
commitAsyncshould be protected under the consumer semaphore, or you get errors like this when trying to callcommitLaterconcurrently withpoll: